gh-144319: madvise(MADV_HUGEPAGE)
#144353
Draft
+3
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hint enables Transparent Huge Pages on systems with
madvise, which seems to be the default on Ubuntu and Fedora, at least according to this article.More on THP:
Importantly, it seems to cary no
SIGBUSrisk. mimalloc seems to already do this withMIMALLOC_LARGE_OS_PAGES=1.Reusing the benchmark from #144319:
bench_obmalloc.py
on
Where the baseline is the
mainbranchWall-clock time
dTLB load misses
It's smaller than
MAP_HUGETLBbecauseMADV_HUGEPAGEis just a hint, so maybe khugepaged did not kick in yet.I noted no regression with
THP=always.The only thing that I'm wondering whether and how it should be guarded. Enabling by default seems risky, but it's not exactly
--with-pymalloc-hugepages. That's why I'm opening this as a draft.Meanwhile, I'm running the whole
pyperformancesuite to check if there are any regressions, I will update this PR description once known.