Skip to content

Conversation

@shayan0v0n
Copy link

@shayan0v0n shayan0v0n commented Jan 28, 2026

Description

Fixed alignment and spacing issues in the search box footer component. The "to close" and "Powered by" sections were improperly aligned and lacked adequate spacing between them. This PR ensures visual consistency and proper layout across light and dark modes.

Changes made:

  • Updated footer CSS from justify-center to justify-between for proper element distribution
  • Added proper margin spacing between keyboard shortcuts and the Powered By section
  • Fixed vertical alignment of Orama logo and text
  • Ensured the footer uses the full width of the search modal
  • Improved responsive behavior for different screen sizes

Validation

Before: The "to close" and "Powered by" sections were touching without proper spacing, and elements were not properly aligned.

After: Proper spacing between sections, all elements are visually aligned, and the footer layout is consistent.

Testing performed:

  • ✅ Verified alignment in light mode
  • ✅ Verified alignment in dark mode
  • ✅ Tested responsiveness on different screen sizes
  • ✅ Confirmed keyboard navigation still functions correctly
  • ✅ Checked that the Powered By link remains clickable and accessible

Screenshot of the fixed alignment:
before:
image

after:
image

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@shayan0v0n shayan0v0n requested a review from a team as a code owner January 28, 2026 09:12
@vercel
Copy link

vercel bot commented Jan 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-org Error Error Jan 30, 2026 5:11pm

Request Review

@github-actions
Copy link
Contributor

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/nodejs-website

Please review the changes when you have a chance. Thank you! 🙏

@shayan0v0n
Copy link
Author

#8570

@paulobelucci
Copy link
Contributor

Hey @shayan0v0n did you try just moving the entire div that contains the powerdByLink, to the shortcutWrapper div? Seems that it works as well, maybe no need to create another class to it.

@shayan0v0n
Copy link
Author

shayan0v0n commented Jan 28, 2026

Hello @paulobelucci, Actually, I need to keep the poweredByLink class because the alignment issue isn't just about horizontal spacing between sections—the text and logo inside the 'Powered by' link itself need specific vertical alignment.
what do you think?

@paulobelucci
Copy link
Contributor

Ok. No problem. My bad, I thought the issue was just with the vertical alignment. 🙌🏼

@aymen94
Copy link
Member

aymen94 commented Jan 29, 2026

Thanks @shayan0v0n for your first contribution 😎, nice work!

@shayan0v0n
Copy link
Author

Glad to hear that 🔥 , @aymen94

@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.02%. Comparing base (6003a64) to head (0a587a6).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8571      +/-   ##
==========================================
+ Coverage   75.01%   75.02%   +0.01%     
==========================================
  Files         103      103              
  Lines        9037     9037              
  Branches      311      311              
==========================================
+ Hits         6779     6780       +1     
+ Misses       2256     2255       -1     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@araujogui araujogui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@araujogui araujogui added this pull request to the merge queue Jan 30, 2026
@araujogui araujogui removed this pull request from the merge queue due to a manual request Jan 30, 2026
Copy link
Member

@araujogui araujogui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

Actually, it's misaligned on mobile, can u remove the margin left on mobile?

@shayan0v0n
Copy link
Author

Excellent catch, @araujogui . Thanks for pointing this out.

@shayan0v0n shayan0v0n requested a review from araujogui January 30, 2026 12:52
Co-authored-by: Guilherme Araújo <arauujogui@gmail.com>
Signed-off-by: The Shawn <82698897+shayan0v0n@users.noreply.github.com>
Signed-off-by: The Shawn <82698897+shayan0v0n@users.noreply.github.com>
Copy link
Member

@araujogui araujogui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code format is still wrong, please run pnpm prettier:fix

@shayan0v0n
Copy link
Author

shayan0v0n commented Jan 30, 2026

Ran pnpm prettier:fix to ensure consistent code formatting. The command completed successfully without errors.
@araujogui

@araujogui
Copy link
Member

@nodejs/nodejs-website can someone with permissions check why the deployment is failing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants