Skip to content

Conversation

@nodejs-crowdin
Copy link
Collaborator

New Crowdin translations from the Node.js Crowdin project

@nodejs-crowdin nodejs-crowdin requested a review from a team as a code owner January 16, 2026 05:14
@vercel
Copy link

vercel bot commented Jan 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-org Ready Ready Preview Jan 30, 2026 5:29am

Request Review

@github-actions
Copy link
Contributor

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/nodejs-website

Please review the changes when you have a chance. Thank you! 🙏

@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.96%. Comparing base (5046ba5) to head (040ea8a).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8557      +/-   ##
==========================================
+ Coverage   74.95%   74.96%   +0.01%     
==========================================
  Files         103      103              
  Lines        9037     9037              
  Branches      312      312              
==========================================
+ Hits         6774     6775       +1     
+ Misses       2261     2260       -1     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2026

📦 Build Size Comparison

Summary

Metric Value
Old Total Size 3.74 MB
New Total Size 3.74 MB
Delta 0 B (0.00%)

Changes

➕ Added Assets (1)
Name Size
.next/static/chunks/f79446d8d21af36f.js 206.15 KB
➖ Removed Assets (1)
Name Size
.next/static/chunks/49847f5e28b57619.js 206.15 KB

...

<PartnersList size="large" category="infrastructure" />
<PartnersList size="large" category="infrastruktur" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think category should be translated.

Copy link
Member

@araujogui araujogui Jan 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prop type is 'infrastructure' | 'esp'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah we always said "don't translate mdx propos" I didn't have perm for that. maybe @avivkeller @bmuenzenmeyer

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
...

<PartnersList size="large" category="infrastructure" />
<PartnersList size="large" category="infrastruktur" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The category prop for PartnersList was translated to "infrastruktur", which is an invalid value. This will cause the component to display no partners in that section.
Severity: HIGH

Suggested Fix

Revert the category prop value in apps/site/pages/id/about/partners.mdx from "infrastruktur" back to "infrastructure". Prop values like this should be treated as code, not translatable text, and should be excluded from translation synchronization processes.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: apps/site/pages/id/about/partners.mdx#L19

Potential issue: The `PartnersList` component on the Indonesian partners page
(`id/about/partners.mdx`) has its `category` prop set to `"infrastruktur"`. This is an
invalid value according to the `PartnerCategory` type, which only allows
`'infrastructure'` or `'esp'`. The component filters partners from `constants.json`
using this prop value. Since no partner data contains the category `"infrastruktur"`,
the filter will return an empty array, causing the "Infrastructure Partners" section to
be empty for users viewing the Indonesian version of the site. This was likely caused by
an automated translation process incorrectly changing a programmatic value.

Did we get this right? 👍 / 👎 to inform future reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants