-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
[automated]: crowdin sync #8557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website Please review the changes when you have a chance. Thank you! 🙏 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8557 +/- ##
==========================================
+ Coverage 74.95% 74.96% +0.01%
==========================================
Files 103 103
Lines 9037 9037
Branches 312 312
==========================================
+ Hits 6774 6775 +1
+ Misses 2261 2260 -1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
📦 Build Size ComparisonSummary
Changes➕ Added Assets (1)
➖ Removed Assets (1)
|
| ... | ||
|
|
||
| <PartnersList size="large" category="infrastructure" /> | ||
| <PartnersList size="large" category="infrastruktur" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think category should be translated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The prop type is 'infrastructure' | 'esp'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah we always said "don't translate mdx propos" I didn't have perm for that. maybe @avivkeller @bmuenzenmeyer
d90a930 to
6312389
Compare
a03c5a4 to
6a243c0
Compare
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
| ... | ||
|
|
||
| <PartnersList size="large" category="infrastructure" /> | ||
| <PartnersList size="large" category="infrastruktur" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The category prop for PartnersList was translated to "infrastruktur", which is an invalid value. This will cause the component to display no partners in that section.
Severity: HIGH
Suggested Fix
Revert the category prop value in apps/site/pages/id/about/partners.mdx from "infrastruktur" back to "infrastructure". Prop values like this should be treated as code, not translatable text, and should be excluded from translation synchronization processes.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: apps/site/pages/id/about/partners.mdx#L19
Potential issue: The `PartnersList` component on the Indonesian partners page
(`id/about/partners.mdx`) has its `category` prop set to `"infrastruktur"`. This is an
invalid value according to the `PartnerCategory` type, which only allows
`'infrastructure'` or `'esp'`. The component filters partners from `constants.json`
using this prop value. Since no partner data contains the category `"infrastruktur"`,
the filter will return an empty array, causing the "Infrastructure Partners" section to
be empty for users viewing the Indonesian version of the site. This was likely caused by
an automated translation process incorrectly changing a programmatic value.
Did we get this right? 👍 / 👎 to inform future reviews.
New Crowdin translations from the Node.js Crowdin project