Skip to content

Add support for string arrays in multipart fields #3029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Zcodeoooo wants to merge 1 commit into
base: release-1.57
Choose a base branch
from
Open

Add support for string arrays in multipart fields #3029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions playwright/_impl/_fetch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
async_readfile,
async_writefile,
is_file_payload,
is_file_array_payload,
locals_to_params,
object_to_array,
to_impl,
Expand Down Expand Up @@ -394,6 +395,14 @@ async def _inner_fetch(
multipart_data.append(
FormField(name=name, file=file_payload_to_json(payload))
)
elif is_file_array_payload(value):
for item in value:
payload = cast(FilePayload, item)
assert isinstance(payload["buffer"], bytes)
multipart_data.append(FormField(name=name, file=file_payload_to_json(payload)))
elif isinstance(value, list):
for item in value:
multipart_data.append(FormField(name=name, value=str(item)))
elif isinstance(value, str):
multipart_data.append(FormField(name=name, value=value))
if (
Expand Down
3 changes: 3 additions & 0 deletions playwright/_impl/_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,6 +561,9 @@ def is_file_payload(value: Optional[Any]) -> bool:
and "buffer" in value
)

def is_file_array_payload(value: Optional[Any]) -> bool:
return isinstance(value, list) and all(is_file_payload(x) for x in value)


TEXTUAL_MIME_TYPE = re.compile(
r"^(text\/.*?|application\/(json|(x-)?javascript|xml.*?|ecmascript|graphql|x-www-form-urlencoded)|image\/svg(\+xml)?|application\/.*?(\+json|\+xml))(;\s*charset=.*)?$"
Expand Down
4 changes: 1 addition & 3 deletions playwright/async_api/_generated.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18229,9 +18229,7 @@ async def delete(
headers: typing.Optional[typing.Dict[str, str]] = None,
data: typing.Optional[typing.Union[typing.Any, str, bytes]] = None,
form: typing.Optional[typing.Dict[str, typing.Union[str, float, bool]]] = None,
multipart: typing.Optional[
typing.Dict[str, typing.Union[bytes, bool, float, str, FilePayload]]
] = None,
multipart: typing.Dict[str,typing.Union[bytes,bool,float,str,FilePayload,typing.List[typing.Union[str, FilePayload]]]] = None,
timeout: typing.Optional[float] = None,
fail_on_status_code: typing.Optional[bool] = None,
ignore_https_errors: typing.Optional[bool] = None,
Expand Down