Skip to content

feat: add since and until date filters to list_commits #1928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
quiloos39 wants to merge 1 commit into
base: main
Choose a base branch
from
+32 −0
Open

feat: add since and until date filters to list_commits #1928

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions pkg/github/repositories.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"net/http"
"net/url"
"strings"
"time"

ghErrors "github.com/github/github-mcp-server/pkg/errors"
"github.com/github/github-mcp-server/pkg/inventory"
Expand Down Expand Up @@ -147,6 +148,14 @@ func ListCommits(t translations.TranslationHelperFunc) inventory.ServerTool {
Type: "string",
Description: "Author username or email address to filter commits by",
},
"since": {
Type: "string",
Description: "Only show commits after this date (ISO 8601 format: YYYY-MM-DDTHH:MM:SSZ)",
},
"until": {
Type: "string",
Description: "Only show commits before this date (ISO 8601 format: YYYY-MM-DDTHH:MM:SSZ)",
},
},
Required: []string{"owner", "repo"},
}),
Expand All @@ -169,6 +178,27 @@ func ListCommits(t translations.TranslationHelperFunc) inventory.ServerTool {
if err != nil {
return utils.NewToolResultError(err.Error()), nil, nil
}
sinceStr, err := OptionalParam[string](args, "since")
if err != nil {
return utils.NewToolResultError(err.Error()), nil, nil
}
untilStr, err := OptionalParam[string](args, "until")
if err != nil {
return utils.NewToolResultError(err.Error()), nil, nil
}
var sinceTime, untilTime time.Time
if sinceStr != "" {
sinceTime, err = time.Parse(time.RFC3339, sinceStr)
if err != nil {
return utils.NewToolResultError(fmt.Sprintf("invalid 'since' date format, expected ISO 8601 (YYYY-MM-DDTHH:MM:SSZ): %s", err.Error())), nil, nil
}
}
if untilStr != "" {
untilTime, err = time.Parse(time.RFC3339, untilStr)
if err != nil {
return utils.NewToolResultError(fmt.Sprintf("invalid 'until' date format, expected ISO 8601 (YYYY-MM-DDTHH:MM:SSZ): %s", err.Error())), nil, nil
}
}
pagination, err := OptionalPaginationParams(args)
if err != nil {
return utils.NewToolResultError(err.Error()), nil, nil
Expand All @@ -181,6 +211,8 @@ func ListCommits(t translations.TranslationHelperFunc) inventory.ServerTool {
opts := &github.CommitsListOptions{
SHA: sha,
Author: author,
Since: sinceTime,
Until: untilTime,
ListOptions: github.ListOptions{
Page: pagination.Page,
PerPage: perPage,
Expand Down