fix(arq): handle settings_cls passed as keyword argument #5393
+56
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_sentry_create_workerpatch assumedsettings_clsis always passed as positional arg (args[0]), causing IndexError when users callcreate_worker(settings_cls=WorkerSettings).Now checks both
args[0]andkwargs.get("settings_cls").Test added in
tests/integrations/arq/test_arq.pyasinit_arq_with_kwarg_settingsDescription
settings_clsis now checked from kwargs if no argsIssues