-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix(core): Fix truncation to only keep last message in vercel #19080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
size-limit report 📦
|
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
GEN_AI_PROMPT_ATTRIBUTEconvertPromptToMessagesdid not handle inputs that were already in messages formats (fallback to[]), which was seemingly the culprit for truncation failingAI_PROMPT_ATTRIBUTEto the truncated messages format irrespective of the input as well, so that we get truncation for the original Vercel attribute as well (before we sent the all messages in the original namespace)Tests:
convertPromptToMessagesproperly handles inputs that are already in messages formatCloses #19060