Skip to content

Fix memorystream local test failure #123709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alinpahontu2912 wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −0
Open

Fix memorystream local test failure #123709

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e715ced
add maximum boundary check for memorystream capacity
alinpahontu2912 Jan 28, 2026
5b2f5e9
Update src/libraries/System.Private.CoreLib/src/System/IO/MemoryStrea…
alinpahontu2912 Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/libraries/System.Private.CoreLib/src/System/IO/MemoryStream.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,8 @@ public virtual int Capacity
// Special behavior if the MS isn't expandable: we don't throw if value is the same as the current capacity
if (value < Length)
throw new ArgumentOutOfRangeException(nameof(value), SR.ArgumentOutOfRange_SmallCapacity);
if (value > MemStreamMaxLength)
throw new ArgumentOutOfRangeException(nameof(value), SR.ArgumentOutOfRange_Capacity);
Copy link
Member

@stephentoub stephentoub Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this always resulted in an OOMException, even on .NET Framework? Or did it used to throw an ArgumentException for this, that regressed, and now this is just fixing the regression?

Copy link
Member

@jozkee jozkee Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use ArgumentOutOfRange_Capacity anywhere else in MemoryStream and what we use in other places e.g. ArgumentOutOfRange_StreamLength, includes the maximum array length:

Stream length must be non-negative and less than the maximum array length {0} - origin.

Should we add a new string mentioning that?


EnsureNotClosed();

Expand Down
Loading