-
Notifications
You must be signed in to change notification settings - Fork 173
Apply Apache Incubator press-kit logo to docs #1438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
hi @skrawcz |
|
@mohit7705 nice. Question - can you make the star a bit bigger to fill the circle more? or is that spacing part of the guidelines? |
|
@mohit7705 would love a minor tweak to what you did thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this one more -- if the star could be a little bit bigger that would be great thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skrawcz
I increased the size of the Hamilton star so it fills the circle better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Updates the documentation homepage to display the Apache Incubator podling logo for Hamilton, aligning the docs with Apache Incubator press-kit guidance (Fixes #1435).
Changes:
- Added a centered incubator logo image to the docs homepage (
docs/index.md).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 3 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
docs/index.md:27
- The
{figure}fenced directive isn’t closed before the{include}directive, so the{include}block is being parsed as part of the figure content. This will likely break the homepage rendering and/or Sphinx build. Close the figure fence (```) right after the caption, then start a new fenced block for{include}.
Apache Hamilton (Incubator Podling) logo
```{include} main.md
</details>
---
💡 <a href="/apache/hamilton/new/main/.github/instructions?filename=*.instructions.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Add Copilot custom instructions</a> for smarter, more guided reviews. <a href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Learn how to get started</a>.
What was done
Notes
Fixes #1435