Add initial implementation of Ruby status bar item showing Ruby version #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
rafaelfranca
force-pushed
the
rmf-first-version-manager
branch
from
940ccbe to
4bc36f3
Compare
rafaelfranca
force-pushed
the
rmf-initial-implementation
branch
from
71bf6b2 to
3c1a046
Compare
…ction in configuration
… version from VS Code settings
Implement the custom executable path version manager that allow users to set rubyExecutablePath in settings. Update the extension to use this new version manager.
Other extension should be the ones chosing when to activate it.
rafaelfranca
force-pushed
the
rmf-first-version-manager
branch
from
4bc36f3 to
5502e4c
Compare
rafaelfranca
force-pushed
the
rmf-initial-implementation
branch
from
3c1a046 to
4e4d276
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial implementation of Ruby status bar item showing Ruby version
Allow user to select Ruby versions via command palette and store selection in configuration
Activate when in a Ruby project using bundler
Introduce the first version manager: ConfiguredRuby, which reads Ruby version from VS Code settings
Implement the first version manager
Implement the custom executable path version manager that allow users to
set rubyExecutablePath in settings. Update the extension to use this new version
manager.
Add output channel to debug problems
Fix activation script
Extract the RubyEnvironment object
Move createVersionManager to inside the object
Remove activateInternal
Move actiavation of Ruby environment to after construction
Use a more discriminated type for RubyDefinition
Remove unneeded sync version of activate
Update README
Test on windows and MacOS
Show all available JITs in the Ruby environment
Remove all activation logic from this extension
Other extension should be the ones chosing when to activate it.